This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14425 ) Change subject: core/utils: drop meaningless const from return value of osmo_luhn() ...................................................................... core/utils: drop meaningless const from return value of osmo_luhn() Change-Id: I085da06f31a0a6862ae2ba041fafc134cc240f7e --- M include/osmocom/core/utils.h M src/utils.c 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h index f27359c..f429ba6 100644 --- a/include/osmocom/core/utils.h +++ b/include/osmocom/core/utils.h @@ -155,7 +155,7 @@ uint32_t osmo_isqrt32(uint32_t x); -const char osmo_luhn(const char* in, int in_len); +char osmo_luhn(const char* in, int in_len); /*! State for OSMO_STRBUF_APPEND() and OSMO_STRBUF_PRINTF(). See there for examples. */ struct osmo_strbuf { diff --git a/src/utils.c b/src/utils.c index c38f530..7b7178c 100644 --- a/src/utils.c +++ b/src/utils.c @@ -993,7 +993,7 @@ * \param[in] in_len Count of digits to use for the input (14 for IMEI). * \returns checksum char (e.g. '3'); negative on error */ -const char osmo_luhn(const char* in, int in_len) +char osmo_luhn(const char* in, int in_len) { int i, sum = 0; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I085da06f31a0a6862ae2ba041fafc134cc240f7e Gerrit-Change-Number: 14425 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190612/12621972/attachment.htm>