Change in ...osmo-ttcn3-hacks[master]: msc: Fix Iu tests timing out due to explicit CM ServiceAccept not recvd

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Jun 3 14:05:01 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14354 )

Change subject: msc: Fix Iu tests timing out due to explicit CM ServiceAccept not recvd
......................................................................

msc: Fix Iu tests timing out due to explicit CM ServiceAccept not recvd

Even if ciphering it not enabled, osmo-msc still sends a
SecurityModeCommand to use IntegrityProtection, and as a result osmo-msc
assumes implicit ACCEPT in all UTRAN CM service requests.

Fixes: OS#3991
Change-Id: Ida91f907dd6dfae68cbc63752ddc6f2948792689
---
M msc/BSC_ConnectionHandler.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn
index c1114a6..b5dbb87 100644
--- a/msc/BSC_ConnectionHandler.ttcn
+++ b/msc/BSC_ConnectionHandler.ttcn
@@ -359,7 +359,7 @@
 	f_cl3_or_initial_ue(l3_info);
 
 	f_mm_common();
-	if (g_pars.net.expect_ciph) {
+	if (g_pars.net.expect_ciph or not g_pars.ran_is_geran) {
 		/* implicit CM SERVICE ACCEPT? */
 	} else {
 		if (etype != EST_TYPE_PAG_RESP) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14354
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ida91f907dd6dfae68cbc63752ddc6f2948792689
Gerrit-Change-Number: 14354
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190603/9784bf35/attachment.htm>


More information about the gerrit-log mailing list