This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14980 ) Change subject: sgsnemu: Fix unaligned pointer access during ip/icmp checksum ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14980/1/sgsnemu/sgsnemu.c File sgsnemu/sgsnemu.c: https://gerrit.osmocom.org/#/c/14980/1/sgsnemu/sgsnemu.c@1285 PS1, Line 1285: memcpy(&v16, p8, 2); > don't we have osmo_load16be or something like that for exactly this kind of situation? To be honest, I'm not sure if that would be the same in this case. iiuc, on a LittleEndian system it would swap the 2 bytes, and we don't want that here? This kind of stuff always confused me a lot... -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I783f104c31234a07f2a13f6dbc577a71b25b36a7 Gerrit-Change-Number: 14980 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at gnumonks.org> Gerrit-Comment-Date: Mon, 29 Jul 2019 18:38:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at gnumonks.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190729/532657c2/attachment.htm>