This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp@123 PS1, Line 123: gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), Did you check what happens on code below if imsi is not set? Adding description about that in the commit would be nice. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401 Gerrit-Change-Number: 14922 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith at rhizomatica.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 24 Jul 2019 10:41:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190724/34752a0a/attachment.htm>