This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libsmpp34/+/14862 ) Change subject: bind_receiver_test: Fix "unused value" of writing addr_ton twice ...................................................................... bind_receiver_test: Fix "unused value" of writing addr_ton twice The constant 0x34 clearly hints that this should be written to interface_version... Closes: CID#135235 Change-Id: I89e16746da5c9f77b721294149a1bce5be5a1eae --- M test_pdu/bind_receiver_test.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/test_pdu/bind_receiver_test.c b/test_pdu/bind_receiver_test.c index fa94c6f..67eab09 100644 --- a/test_pdu/bind_receiver_test.c +++ b/test_pdu/bind_receiver_test.c @@ -53,7 +53,7 @@ snprintf((char*)b.system_id, sizeof(b.system_id), "%s", "system_id"); snprintf((char*)b.password, sizeof(b.password), "%s", "pass"); snprintf((char*)b.system_type, sizeof(b.system_type), "%s", "syste"); - b.addr_ton = 0x34; + b.interface_version = 0x34; b.addr_ton = 2; b.addr_npi = 1; snprintf((char*)b.address_range, sizeof(b.address_range), "%s", "address_range"); -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/14862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I89e16746da5c9f77b721294149a1bce5be5a1eae Gerrit-Change-Number: 14862 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190721/95af4a36/attachment.htm>