This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14870 ) Change subject: ipaccess.c: Avoid calling close(-1) on error path ...................................................................... ipaccess.c: Avoid calling close(-1) on error path Change-Id: Idabb9805a4a10c95ba0e01bc3f80ed8db87a9f85 Closes: CID#157118 --- M src/input/ipaccess.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index fb6ad10..474bfb4 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -215,8 +215,10 @@ return 0; err: osmo_fd_unregister(bfd); - close(bfd->fd); - bfd->fd = -1; + if (bfd->fd != -1) { + close(bfd->fd); + bfd->fd = -1; + } e1inp_line_put(line); return -1; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14870 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Idabb9805a4a10c95ba0e01bc3f80ed8db87a9f85 Gerrit-Change-Number: 14870 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190721/f397e40e/attachment.htm>