This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14696 ) Change subject: Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for rest_bits ...................................................................... Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for rest_bits The rest_bits are never read after calling this function nor are rest_bits updated properly. Change-Id: Ic350b0365b125638a6c752f692bef981ad6b9d89 --- M src/encoding.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Vadim Yanitskiy: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/encoding.cpp b/src/encoding.cpp index a290c65..d253dac 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -830,7 +830,7 @@ static void write_packet_ack_nack_desc_egprs( bitvec * dest, unsigned& wp, - gprs_rlc_ul_window *window, bool is_final, unsigned& rest_bits) + gprs_rlc_ul_window *window, bool is_final, unsigned rest_bits) { unsigned int urbb_len = 0; uint8_t crbb_len = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14696 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic350b0365b125638a6c752f692bef981ad6b9d89 Gerrit-Change-Number: 14696 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190710/e730cc23/attachment.htm>