Change in ...libosmo-abis[master]: extend the ipa keepalive fsm

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed Jul 10 19:50:59 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14742 )

Change subject: extend the ipa keepalive fsm
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

I know my comments can be annoying, but I believe we should keep the code consistent.

https://gerrit.osmocom.org/#/c/14742/1/include/osmocom/abis/ipa.h 
File include/osmocom/abis/ipa.h:

https://gerrit.osmocom.org/#/c/14742/1/include/osmocom/abis/ipa.h@129 
PS1, Line 129:                                                            
You're changing tabs to spaces, keeping code unchanged.


https://gerrit.osmocom.org/#/c/14742/1/src/input/ipa_keepalive.c 
File src/input/ipa_keepalive.c:

https://gerrit.osmocom.org/#/c/14742/1/src/input/ipa_keepalive.c@290 
PS1, Line 290:     
Same here. Tabs are used in the existing code.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14742
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b
Gerrit-Change-Number: 14742
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 10 Jul 2019 19:50:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190710/75be9d69/attachment.htm>


More information about the gerrit-log mailing list