Change in ...osmo-pcap[master]: tests/Makefile.am: Fix "./configure && make clean && make"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 4 13:38:23 UTC 2019


pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14666 )

Change subject: tests/Makefile.am: Fix "./configure && make clean && make"
......................................................................

tests/Makefile.am: Fix "./configure && make clean && make"

Without this patch, make check fails with following error:
No rule to make target 'atconfig', needed by 'check-local'

Changes needed to fix the issue were gathered by looking at differences
with libosmo-netif's Makefile.

Change-Id: Ie6698d1c1d36e2b8a5391bc2322c1632458751db
---
M tests/Makefile.am
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  osmith: Looks good to me, approved; Verified
  Jenkins Builder: Verified



diff --git a/tests/Makefile.am b/tests/Makefile.am
index def6e8b..720d631 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -17,6 +17,7 @@
              } >'$(srcdir)/package.m4'
      
 EXTRA_DIST = testsuite.at $(srcdir)/package.m4 $(TESTSUITE)
+DISTCLEANFILES = atconfig
 TESTSUITE = $(srcdir)/testsuite
 
 if ENABLE_EXT_TESTS
@@ -39,7 +40,6 @@
 clean-local:
 	test ! -f '$(TESTSUITE)' || \
 		$(SHELL) '$(TESTSUITE)' --clean
-	$(RM) -f atconfig
      
 AUTOM4TE = $(SHELL) $(top_srcdir)/missing --run autom4te
 AUTOTEST = $(AUTOM4TE) --language=autotest

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14666
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: Ie6698d1c1d36e2b8a5391bc2322c1632458751db
Gerrit-Change-Number: 14666
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190704/56748618/attachment.htm>


More information about the gerrit-log mailing list