Change in ...osmo-bts[master]: osmo-bts/scheduler: provide actual C/I values to OsmoPCU

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Wed Jul 3 11:14:35 UTC 2019


tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14613 )

Change subject: osmo-bts/scheduler: provide actual C/I values to OsmoPCU
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

This change is ready for review.

https://gerrit.osmocom.org/#/c/14613/3/src/osmo-bts-trx/scheduler_trx.c 
File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/#/c/14613/3/src/osmo-bts-trx/scheduler_trx.c@986 
PS3, Line 986: 	uint8_t *ci_cb_num = &chan_state->ci_cb_num;
> picky comment: Can we name it ci_cb_count? otherwise it's difficult to differentiate it with ci_cb_s […]
But they're already all named _num ...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14613
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia58043bd2381a4d34d604522e02899ae64ee0d26
Gerrit-Change-Number: 14613
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Wed, 03 Jul 2019 11:14:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190703/4f69c738/attachment.htm>


More information about the gerrit-log mailing list