Change in osmo-sysmon[master]: Add ping probe support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Wed Jan 30 15:14:49 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/12710 )

Change subject: Add ping probe support
......................................................................


Patch Set 9: Code-Review-1

(2 comments)

It seems like config.h is not needed, otherwise everything looks fine to me.

https://gerrit.osmocom.org/#/c/12710/9//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12710/9//COMMIT_MSG@29
PS9, Line 29: 
nitpick: empty line here


https://gerrit.osmocom.org/#/c/12710/9/src/osysmon.h
File src/osysmon.h:

https://gerrit.osmocom.org/#/c/12710/9/src/osysmon.h@9
PS9, Line 9: #include "config.h"
Why is config.h needed?



-- 
To view, visit https://gerrit.osmocom.org/12710
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife32540b532fb54368f63c78fb7837b84d4e8c76
Gerrit-Change-Number: 12710
Gerrit-PatchSet: 9
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Jan 2019 15:14:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190130/3353d144/attachment.htm>


More information about the gerrit-log mailing list