This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12571 ) Change subject: VLR: use msgb_eq_data_print() for comparison ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG@9 PS1, Line 9: This simplifies tests refactoring by showing exact byte where mismatch > > that's technically not allowed […] Max, I'm really not happy about you repeatedly trying to change how things are done. In osmocom, we never have had any multiline logging. This ispart of the log file format. Whether or not it's not technically posibble, you should have concluded from the fact that it's not done anywhere that it's not desired/intended. I'm actually going to open a bug report about this now. How do you expect any automatic log post-processing to work when suddenly there are log lines that don't follow the usual formatting? Have you validated/verified that e.g. the GSMTAP based logging still works with this multi-line approach? Have you verified that the rendering e.g. in the GSMTAP log dissector for wireshark works? And there are more questions like this - whihc I all find rather rhethorically because it simply shouldn't be done in the first place. I believe the PCU did that at some point in the past or maybe still using multi-line log strings. If so, they should equally be resolved/reoved. -- To view, visit https://gerrit.osmocom.org/12571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9771c973f2bc55580f4c146bdbeeb1609d56786 Gerrit-Change-Number: 12571 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Tue, 29 Jan 2019 12:48:59 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190129/d90d4e2a/attachment.htm>