This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12682 )
Change subject: Support Emergency Calling
......................................................................
Patch Set 8: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/12682/8/src/mncc.c
File src/mncc.c:
https://gerrit.osmocom.org/#/c/12682/8/src/mncc.c@429
PS8, Line 429: osmo_strlcpy((char *)data->called.number, "emergency", sizeof(data->called.number));
The original author made data const on purpose: the buffer passed into this function must not be modified.
You need to create a local copy to modify it.
https://gerrit.osmocom.org/#/c/12682/8/src/mncc.c@430
PS8, Line 430: } else {
use
} else if ((data->fields....) {
--
To view, visit https://gerrit.osmocom.org/12682
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1
Gerrit-Change-Number: 12682
Gerrit-PatchSet: 8
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 29 Jan 2019 00:23:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190129/c757a959/attachment.htm>