This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has posted comments on this change. ( https://gerrit.osmocom.org/12706 )
Change subject: Support International Caller ID
......................................................................
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/12706/2/src/mncc.c
File src/mncc.c:
https://gerrit.osmocom.org/#/c/12706/2/src/mncc.c@783
PS2, Line 783: if (strncmp(call->source, "+", 1) == 0) {
Since you're comparing just a single character you can do it directly like:
call->source[0] != '+'
provided call->source is initialized.
https://gerrit.osmocom.org/#/c/12706/2/src/mncc.c@785
PS2, Line 785: osmo_strlcpy(mncc.calling.number, call->source + 1, sizeof(mncc.calling.number));
Curious, so in case of international number format, the + sign is not actually transmitted - didn't know that.
Do you recall spec. which describe this?
--
To view, visit https://gerrit.osmocom.org/12706
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcfa31aff90e04dd0aa3583957f288889b1bbefe
Gerrit-Change-Number: 12706
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Jan 2019 14:46:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190128/32c8ec21/attachment.htm>