Change in osmo-sysmon[master]: Drop unused parameter

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12705 )

Change subject: Drop unused parameter
......................................................................


Patch Set 1:

> don't you think the bug is rather that the talloc inside value_node_add is using 'parent' instead of 'ctx'?

I'm not sure: the only case where they differ is root node allocation inside while(1){...} in main() - and it's deallocated at the end of each iteration.

> I don't recall the details.  My suspicion is that originally not all nodes were dynamically allocated and hence the ctx would need to be specified explicitly.  If that's no longer the case, than it appears we can go for removing the argument like in your patch.

I see, that make sense. I've checked all the places where it's called only with dynamically allocated parent so I think it's ok to drop it.


-- 
To view, visit https://gerrit.osmocom.org/12705
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17c2fed4049e1c83307feda001aefc006dfbe6a3
Gerrit-Change-Number: 12705
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Mon, 28 Jan 2019 10:29:00 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190128/258497d9/attachment.htm>