Change in osmo-sip-connector[master]: Support Emergency Calling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Jan 28 10:07:14 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/12682 )

Change subject: Support Emergency Calling
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/#/c/12682/4/src/mncc.c
File src/mncc.c:

https://gerrit.osmocom.org/#/c/12682/4/src/mncc.c@415
PS4, Line 415: 	struct gsm_mncc *data;
> Is this OK or has some other consequences?
It's natuaral - you're changing it so it's not const.


https://gerrit.osmocom.org/#/c/12682/4/src/mncc.c@429
PS4, Line 429: 		data->fields |= MNCC_F_CALLED;
I'd rather use osmo_strlcpy() in here. Do we know the size of data->called.number?



-- 
To view, visit https://gerrit.osmocom.org/12682
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1
Gerrit-Change-Number: 12682
Gerrit-PatchSet: 4
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Jan 2019 10:07:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190128/7bb73d3d/attachment.htm>


More information about the gerrit-log mailing list