This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12625 ) Change subject: assignment_fsm: fix channel allocator preferences ...................................................................... Patch Set 4: Code-Review+1 (3 comments) https://gerrit.osmocom.org/#/c/12625/2/include/osmocom/bsc/codec_pref.h File include/osmocom/bsc/codec_pref.h: https://gerrit.osmocom.org/#/c/12625/2/include/osmocom/bsc/codec_pref.h@24 PS2, Line 24: const struct gsm_bts *bts, enum rate_pref rate_pref); > in ch_mode_rate, we add a 'bool full_rate', and we also add a 'rate_pref'? […] Also talked about this in person, and obviously ch_mode_rate is an out-argument, while the rate_pref is an input argument. I got confused about that because the function internals looked as if they were using ch_mode_rate->full rate as input, and overlooked that before using ch_mode_rate->full_rate, that value is already set, and it is in fact not an in-arg. https://gerrit.osmocom.org/#/c/12625/4/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/#/c/12625/4/include/osmocom/bsc/gsm_data.h@121 PS4, Line 121: struct channel_mode_and_rate ch_mode_rate_alt; > Are there really only two possible mode,rate combinations? […] We talked in person, and there really are only two possible outcomes: one for an FR and one for an HR lchan. So keeping exactly two preferences is perfectly correct. Keeping the lchan_select() out of the codec iteration is also a good idea in terms of complexity of that loop, and in terms of separate testability. https://gerrit.osmocom.org/#/c/12625/4/include/osmocom/bsc/gsm_data.h@300 PS4, Line 300: struct channel_mode_and_rate ch_mode_rate; put this in the user_plane scope? -- To view, visit https://gerrit.osmocom.org/12625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51 Gerrit-Change-Number: 12625 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 24 Jan 2019 15:46:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190124/39dd479f/attachment.htm>