Change in osmo-sip-connector[master]: Support Emergency Calling

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12682 )

Change subject: Support Emergency Calling
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c
File src/mncc.c:

https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c@427
PS1, Line 427: 	if (data->emergency) {
> This "works", but looks wrong, even to me. […]
which part?  I thin the if (data->emergency) is correct. However, the goto is ugly in this situation.  I think you simply need to do "if (!data->emergency) {" and then indent the entire block below.

The other way of approaching this would be to have osmo-msc map the "GSM Special emergency" call already to a destination number (with specified TON / NPI) and this way have no special case handling here?  We could still keep the "emergency" field to indicate that this was an emergency call that was remapped.

Is there some standard way how to express emergency calls in SIP?



-- 
To view, visit https://gerrit.osmocom.org/12682
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1
Gerrit-Change-Number: 12682
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 22 Jan 2019 15:13:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190122/d4edcd71/attachment.htm>