Change in libosmocore[master]: add osmo_hexdump_buf() and test

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Jan 22 00:24:09 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12658 )

Change subject: add osmo_hexdump_buf() and test
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/#/c/12658/5/src/utils.c
File src/utils.c:

https://gerrit.osmocom.org/#/c/12658/5/src/utils.c@230
PS5, Line 230:  *  \returns out_buf, containing a zero-terminated string, or NULL if out_buf == NULL or out_buf_size < 1.
thinking now, maybe should rather return "" if the out_buf is NULL or zero length?



-- 
To view, visit https://gerrit.osmocom.org/12658
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I590595567b218b24e53c9eb1fd8736c0324d371d
Gerrit-Change-Number: 12658
Gerrit-PatchSet: 5
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Jan 2019 00:24:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190122/eebc785f/attachment.htm>


More information about the gerrit-log mailing list