This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12625 ) Change subject: assignment_fsm: fix channel allocator preferences ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/#/c/12625/2/include/osmocom/bsc/codec_pref.h File include/osmocom/bsc/codec_pref.h: https://gerrit.osmocom.org/#/c/12625/2/include/osmocom/bsc/codec_pref.h@24 PS2, Line 24: const struct gsm_bts *bts, enum rate_pref rate_pref); in ch_mode_rate, we add a 'bool full_rate', and we also add a 'rate_pref'? That seems redundant to me / more complex for error checking, because I could technically pass ch_mode_rate->full_rate = false and rate_pref = RATE_PREF_HR. would it make more sense to add an enum rate_pref to channel_mode_and_rate, instead of the bool? Or instead of enum rate_pref, add a "bool strict_rate_pref", to say whether the ch_mode_rate->full_rate flag is important or can be overruled? https://gerrit.osmocom.org/#/c/12625/2/src/osmo-bsc/assignment_fsm.c File src/osmo-bsc/assignment_fsm.c: https://gerrit.osmocom.org/#/c/12625/2/src/osmo-bsc/assignment_fsm.c@255 PS2, Line 255: struct channel_mode_and_rate *ch_mode_rate) const struct ... https://gerrit.osmocom.org/#/c/12625/2/src/osmo-bsc/assignment_fsm.c@305 PS2, Line 305: static int check_voice_stream_needed(struct gsm_subscriber_connection *conn, struct osmo_fsm_inst *fi) (we already have a flag around called "requires_voice_stream", so prefer if this is called "check_requires_voice_stream()") https://gerrit.osmocom.org/#/c/12625/2/src/osmo-bsc/assignment_fsm.c@324 PS2, Line 324: result_pref = false; don't understand the name 'result_pref' ... from surrounding code I guess 'requires_voice' is better? -- To view, visit https://gerrit.osmocom.org/12625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51 Gerrit-Change-Number: 12625 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Mon, 21 Jan 2019 18:17:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190121/b0f784de/attachment.htm>