Change in osmo-bsc[master]: lchan_select: dont allow half rate EFR to be selected

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Mon Jan 21 15:47:52 UTC 2019


dexter has posted comments on this change. ( https://gerrit.osmocom.org/12622 )

Change subject: lchan_select: dont allow half rate EFR to be selected
......................................................................


Patch Set 2:

(2 comments)

> I removed the +2 vote to prevent accidental "submit including
 > parents". Gladly re-add the +2 vote when the wording and missing
 > fall-through comment are fixed

I see. I already corrected the issue, but its not pushed yet since I am not entirely through with all problems of this patch set.

https://gerrit.osmocom.org/#/c/12622/1/src/osmo-bsc/lchan_select.c
File src/osmo-bsc/lchan_select.c:

https://gerrit.osmocom.org/#/c/12622/1/src/osmo-bsc/lchan_select.c@140
PS1, Line 140: EFR works over FR channels only */
> This comment looks confusing. Let's rather say: […]
Done


https://gerrit.osmocom.org/#/c/12622/1/src/osmo-bsc/lchan_select.c@143
PS1, Line 143: 		/* fall through */
> Please add some "fall-through" comment here to suppress Coverity / compiler warnings.
Done



-- 
To view, visit https://gerrit.osmocom.org/12622
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I961d9aaba81424053ab1dc04ce7799e716af4cd8
Gerrit-Change-Number: 12622
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Jan 2019 15:47:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190121/3bb1499d/attachment.htm>


More information about the gerrit-log mailing list