This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12624 ) Change subject: bsc_vty: add features to disable specific lchans via vty ...................................................................... Patch Set 2: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/12624/2/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/#/c/12624/2/include/osmocom/bsc/gsm_data.h@619 PS2, Line 619: bool disabled; In general I dislike double-negation booleans, enabled = false is much more straightforward. Vadim has a point, I would prefer to not add a separate flag and instead put an lchan in LCHAN_ST_BORKEN state. It will then remain unusable until manual intervention. This could also make more sense on the VTY API: a command like "lchan set broken" is obviously a feature no operator would misunderstand as something useful besides a broken BTS, and maybe in that case laforge would agree to keep it in the vty reference manual? https://gerrit.osmocom.org/#/c/12624/2/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/#/c/12624/2/src/osmo-bsc/bsc_vty.c@1447 PS2, Line 1447: bool all) why do you add this 'all' flag? https://gerrit.osmocom.org/#/c/12624/2/src/osmo-bsc/bsc_vty.c@1570 PS2, Line 1570: "Short summary (in use lchans)\n" "used lchans" This is unrelated to a debugging flag https://gerrit.osmocom.org/#/c/12624/2/src/osmo-bsc/bsc_vty.c@1578 PS2, Line 1578: "show lchan all [<0-255>] [<0-255>] [<0-7>] [<0-7>]", why pass TS and subslot arguments to "show lchan all"? I thought it shows them all? So far the semantics are that 'show lchan summary 1 2' shows BTS 1 TS 2, and 'show lchan summary' shows all. So I oppose adding this command. What is the goal -- do you want to achieve printing out all disabled lchans? then use that flag to trigger printing? Maybe we can also talk about this in person to figure out how to best achieve what you need. https://gerrit.osmocom.org/#/c/12624/2/src/osmo-bsc/lchan_select.c File src/osmo-bsc/lchan_select.c: https://gerrit.osmocom.org/#/c/12624/2/src/osmo-bsc/lchan_select.c@83 PS2, Line 83: if (lchan->fi->state == LCHAN_ST_UNUSED && lchan->disabled == false) > At this point I've got an idea: what if we introduce a special FSM state for that? For example, LCHA […] you can re-use LCHAN_ST_BORKEN -- To view, visit https://gerrit.osmocom.org/12624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397e68e26d6a1727890353fa34f4897b54795866 Gerrit-Change-Number: 12624 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Mon, 21 Jan 2019 14:15:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190121/9d373a72/attachment.htm>