This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12624 ) Change subject: bsc_vty: add features to disable specific lchans via vty ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/12624/2/src/osmo-bsc/lchan_select.c File src/osmo-bsc/lchan_select.c: https://gerrit.osmocom.org/#/c/12624/2/src/osmo-bsc/lchan_select.c@83 PS2, Line 83: if (lchan->fi->state == LCHAN_ST_UNUSED && lchan->disabled == false) At this point I've got an idea: what if we introduce a special FSM state for that? For example, LCHAN_ST_DISABLED. This way we wouldn't need to change this. https://gerrit.osmocom.org/#/c/12624/2/src/osmo-bsc/lchan_select.c@89 PS2, Line 89: ws https://gerrit.osmocom.org/#/c/12624/2/src/osmo-bsc/lchan_select.c@94 PS2, Line 94: lchan->disabled ? "disabled" : "not suitable" This additional logging would also be unneeded. -- To view, visit https://gerrit.osmocom.org/12624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397e68e26d6a1727890353fa34f4897b54795866 Gerrit-Change-Number: 12624 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Fri, 18 Jan 2019 11:00:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190118/9f1668ae/attachment.htm>