Change in osmo-msc[master]: Log transaction allocation errors as such

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Thu Jan 17 14:36:40 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/12615 )

Change subject: Log transaction allocation errors as such
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12615/1/src/libmsc/transaction.c
File src/libmsc/transaction.c:

https://gerrit.osmocom.org/#/c/12615/1/src/libmsc/transaction.c@112
PS1, Line 112: DVLR
> Why changing this?

Because absence of VLR subscriber is error.

> And why DVLR?

Because absence of VLR subscriber is error related to VLR, not Call Control.

> Rather do this in a separate change

I'd rather not: it's completely pointless to split every single line into separate commit. Especially when the changes are directly related as is in this case.



-- 
To view, visit https://gerrit.osmocom.org/12615
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I617be8793b9416ccd49022c72f7d93df7f4fb4d9
Gerrit-Change-Number: 12615
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Jan 2019 14:36:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190117/8b3977f9/attachment.htm>


More information about the gerrit-log mailing list