Change in osmo-msc[master]: Don't send Alert Notifications to ESME not bound for RX

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Keith Whyte gerrit-no-reply at lists.osmocom.org
Thu Jan 17 13:59:05 UTC 2019


Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12599 )

Change subject: Don't send Alert Notifications to ESME not bound for RX
......................................................................


Patch Set 2:

> Why is that? 

In short, I guess I was thinking to work around what looks like a big failure in the python-smpplib; in that it is expecting the response to the _last_ message _it_ sent in the _next_ received PDU, whereas, with many LURs/sec going on, it often gets an alert_notification. :(

This can even happen on the bind_transmitter command

So I figured, bind it as a transmitter and we won't get "unsolicited" PDUs

But you are right, I misinterpreted the spec:

"An ESME indicates its desire not to receive (mobile) originated messages from other SME’s
(e.g. mobile stations) by binding as a Transmitter."

it says MO messages, says nothing about alert notifications.

Hmm.. I know we really don't want to work around other software's bugs, but given the lack of SMPP libraries out there, I wonder if this could become an obscure smpp config option useful to anybody.

"no tx-to-transmitter" or some such. 

I'm guessing we /really/ don't want to go down that road. :)

So.. the other patch that allows to exclude an ESME will help in binding an ESME in tranceiver mode for SMS but I guess python-smpplib HAS to be fixed, otherwise you cannot ever get away from this transaction possibility:

ESME -> bind_transmitter - > SMSC
SMSC -> alert_notification - > ESME
ESME "huh I was expecting bind_transmitter_resp?"


-- 
To view, visit https://gerrit.osmocom.org/12599
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec92d4c145ca050c2e212139572eeaae581b99df
Gerrit-Change-Number: 12599
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Thu, 17 Jan 2019 13:59:05 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190117/697732e6/attachment.htm>


More information about the gerrit-log mailing list