Change in osmo-msc[master]: Handle LCLS-NOTIFICATION message from BSS

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12608


Change subject: Handle LCLS-NOTIFICATION message from BSS
......................................................................

Handle LCLS-NOTIFICATION message from BSS

Change-Id: Ibf5f9cad1f70aee56d5bca8fe09a24ca417e7a63
Related: OS#2487
---
M src/libmsc/a_iface_bssap.c
1 file changed, 26 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/08/12608/1

diff --git a/src/libmsc/a_iface_bssap.c b/src/libmsc/a_iface_bssap.c
index 41af93c..12a7af6 100644
--- a/src/libmsc/a_iface_bssap.c
+++ b/src/libmsc/a_iface_bssap.c
@@ -585,6 +585,30 @@
 	return 0;
 }
 
+/* Handle incoming LCLS-NOTIFICATION BSSMAP message: 3GPP TS 48.008 §3.2.1.93 */
+static int bssmap_rx_lcls_notif(const struct ran_conn *conn, const struct msgb *msg, const struct tlv_parsed *tp)
+{
+	/* Either §3.2.2.119 LCLS-BSS-Status (GSM0808_LCLS_STS*) or §3.2.2.120 LCLS-Break-Request shall be present */
+	if (TLVP_PRESENT(tp, GSM0808_IE_LCLS_BSS_STATUS) && TLVP_PRESENT(tp, GSM0808_IE_LCLS_BREAK_REQ)) {
+		LOGPCONN(conn, LOGL_ERROR, "Ignoring broken LCLS Notification message\n");
+	}
+
+	if (TLVP_PRESENT(tp, GSM0808_IE_LCLS_BSS_STATUS)) {
+		uint8_t *status = TLVP_VAL(tp, GSM0808_IE_LCLS_BSS_STATUS);
+		LOGPCONN(conn, LOGL_NOTICE, "Received LCLS Status %s\n", gsm0808_lcls_status_name(*status));
+		return 0;
+	}
+
+	if (TLVP_PRESENT(tp, GSM0808_IE_LCLS_BREAK_REQ)) {
+		LOGPCONN(conn, LOGL_NOTICE, "Received LCLS Break Request\n");
+		return 0;
+	}
+
+	LOGPCONN(conn, LOGL_ERROR, "Received empty LCLS Notification\n");
+
+	return 0;
+}
+
 /* Handle incoming connection oriented BSSMAP messages */
 static int rx_bssmap(struct osmo_sccp_user *scu, const struct a_conn_info *a_conn_info, struct msgb *msg)
 {
@@ -646,6 +670,8 @@
 		return bssmap_rx_sapi_n_rej(conn, msg, &tp);
 	case BSS_MAP_MSG_ASSIGMENT_COMPLETE:
 		return bssmap_rx_ass_compl(conn, msg, &tp);
+	case BSS_MAP_MSG_LCLS_NOTIFICATION:
+		return bssmap_rx_lcls_notif(conn, msg, &tp);
 	default:
 		LOGPCONN(conn, LOGL_ERROR, "Unimplemented msg type: %s\n", gsm0808_bssmap_name(msg_type));
 		return -EINVAL;

-- 
To view, visit https://gerrit.osmocom.org/12608
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf5f9cad1f70aee56d5bca8fe09a24ca417e7a63
Gerrit-Change-Number: 12608
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190117/9f67972d/attachment.htm>