Change in libosmocore[master]: socket: add define for socket name length

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Jan 16 15:49:27 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/12554 )

Change subject: socket: add define for socket name length
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12554/2/src/socket.c
File src/socket.c:

https://gerrit.osmocom.org/#/c/12554/2/src/socket.c@786
PS2, Line 786: 	/* "r=1.2.3.4:123<->l=5.6.7.8:987" */
It might make sense to move the comment as well: the format is explained in doxygen already. Without this comments it completely unclear where all the ..+ 1 + 5... come from.



-- 
To view, visit https://gerrit.osmocom.org/12554
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8be8c2c0d4935da17ab13b2c2127b719ceefbcc
Gerrit-Change-Number: 12554
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Jan 2019 15:49:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190116/c2c6ac91/attachment.htm>


More information about the gerrit-log mailing list