Change in osmo-hlr[master]: Add IMEI column to subscriber table

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12525 )

Change subject: Add IMEI column to subscriber table
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.osmocom.org/#/c/12525/3//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12525/3//COMMIT_MSG@28
PS3, Line 28: [2] change-id I1af7b573ca2a1cb22497052665012d9c1acf3b30
> yes, but the unit test could easily just SEL by imsi again
right


https://gerrit.osmocom.org/#/c/12525/4/src/db_hlr.c
File src/db_hlr.c:

https://gerrit.osmocom.org/#/c/12525/4/src/db_hlr.c@426
PS4, Line 426: 		LOGP(DAUC, LOGL_ERROR, "Update IMEI for subscriber IMSI='%s': SQL modified %d rows (expected 1)\n",
> Argh hm, there's one thing I so far completely missed in this: would SQLite return 0 if the IMEI is  […]
Oh, I've missed that too! Now that you say it, I ran into this with MySQL once: getting 0 rows modified instead of 1 when updating with the same data.

But we got lucky here, SQLite does not behave this way (see the added test).



-- 
To view, visit https://gerrit.osmocom.org/12525
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If232c80bea35d5c6864b889ae92d477eeaa3f45d
Gerrit-Change-Number: 12525
Gerrit-PatchSet: 5
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Jan 2019 14:38:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190116/86a65fcd/attachment.htm>