Change in osmo-msc[master]: Log: don't print CallRef prefix

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12570 )

Change subject: Log: don't print CallRef prefix
......................................................................


Patch Set 2: Code-Review-2

(1 comment)

https://gerrit.osmocom.org/#/c/12570/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12570/2//COMMIT_MSG@9
PS2, Line 9: let's update test output by
           : ignoring first byte of callref
In case of transaction ID, I wasn't sure if we should remove TI flag,
but here I am definitely against. I don't see any advantages of removing
the first byte of callref, vice versa, I see a few potential problems:

  - Let's say we have a few transactions (SMS + USSD during a call):
    CC=0x80000001, SMS=0x40000001, NCSS=0x20000001. Without the
    prefix, they would all look like a single transaction in logging.

  - We have no any protection against possible overlaps between the
    callref ranges (0x20..., 0x40..., 0x80...). This patch makes
    impossible to detect such situations in logging.

Instead, I would drop this range (or per-protocol namespace) separation
itself, because I don't see any benefits of this concept.



-- 
To view, visit https://gerrit.osmocom.org/12570
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icae21a44c7d4010145bcb570187ce9b58092e5a9
Gerrit-Change-Number: 12570
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 15 Jan 2019 18:01:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190115/06a22d4a/attachment.htm>