This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/12526 ) Change subject: Optionally store IMEI in subscriber table ...................................................................... Patch Set 5: (3 comments) https://gerrit.osmocom.org/#/c/12526/4/src/hlr.c File src/hlr.c: https://gerrit.osmocom.org/#/c/12526/4/src/hlr.c@442 PS4, Line 442: msg_out = msgb_alloc_headroom(1024+16, 16, "GSUP Check_IMEI response"); > if the subscriber doesn't exist, we should respond with an error. […] Agreed, all suggestions implemented. update_imei() is gone now, as it would only wrap db_update_imei_by_imsi() (no need to resolve the ID first). https://gerrit.osmocom.org/#/c/12526/4/src/hlr_vty.c File src/hlr_vty.c: https://gerrit.osmocom.org/#/c/12526/4/src/hlr_vty.c@75 PS4, Line 75: vty_out(vty, " store-imei%s", VTY_NEWLINE); > looks like too much indent. […] Right, it should only be one space. Fixed, and extended one of the VTY tests to print this out. https://gerrit.osmocom.org/#/c/12526/4/src/hlr_vty.c@313 PS4, Line 313: " Check IMEI requests (for OsmoMSC, you may want to set 'check-imei-rqd 1').") > wording: maybe rather "Note that an MSC does not necessarily send Check IMEI requests (for OsmoMSC, […] I went with store-imei/no store-imei and changed the wording as suggested. -- To view, visit https://gerrit.osmocom.org/12526 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09274ecbed64224f7ae305e09ede773931da2a57 Gerrit-Change-Number: 12526 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jan 2019 13:38:48 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190115/71967367/attachment.htm>