This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/12525 ) Change subject: Add IMEI column to subscriber table ...................................................................... Patch Set 3: (4 comments) https://gerrit.osmocom.org/#/c/12525/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12525/3//COMMIT_MSG@15 PS3, Line 15: to operate with databases which are not upgraded. > (would suffice to just say "upgrade the db schema to version N", no need to explain the general upgr […] Done https://gerrit.osmocom.org/#/c/12525/3//COMMIT_MSG@28 PS3, Line 28: specification. > also mention that the subscr_get_by_imei() is used by commit "VTY: Integrate IMEI" with change-id. […] Done. Just to make clear, this is also used with "ASSERT_SEL(imei,..." in db_test.c. https://gerrit.osmocom.org/#/c/12525/3/src/db.h File src/db.h: https://gerrit.osmocom.org/#/c/12525/3/src/db.h@76 PS3, Line 76: char imei[32]; > GSM23003_IMEI_NUM_DIGITS + 1 Done https://gerrit.osmocom.org/#/c/12525/3/src/db_hlr.c File src/db_hlr.c: https://gerrit.osmocom.org/#/c/12525/3/src/db_hlr.c@392 PS3, Line 392: * \param[in] imei ASCII string of identifier digits, or NULL to remove the IMEI. > test passing NULL as arg to remove IMEI; then also the remainder of the expected test output would b […] Good idea, done. -- To view, visit https://gerrit.osmocom.org/12525 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If232c80bea35d5c6864b889ae92d477eeaa3f45d Gerrit-Change-Number: 12525 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jan 2019 13:34:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190115/44052eca/attachment.htm>