Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon Jan 14 23:52:32 UTC 2019


Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12547 )

Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message
......................................................................

trx_toolkit/{ctrl,data}_if.py: add init log message

Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
---
M src/target/trx_toolkit/ctrl_if.py
M src/target/trx_toolkit/ctrl_if_trx.py
M src/target/trx_toolkit/data_if.py
3 files changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, but someone else must approve
  Vadim Yanitskiy: Looks good to me, approved
  Jenkins Builder: Verified

Objections:
  Max: I would prefer this is not merged as is



diff --git a/src/target/trx_toolkit/ctrl_if.py b/src/target/trx_toolkit/ctrl_if.py
index 45bfa2b..a1c19f0 100644
--- a/src/target/trx_toolkit/ctrl_if.py
+++ b/src/target/trx_toolkit/ctrl_if.py
@@ -27,6 +27,10 @@
 from udp_link import UDPLink
 
 class CTRLInterface(UDPLink):
+	def __init__(self, *udp_link_args):
+		UDPLink.__init__(self, *udp_link_args)
+		log.debug("Init CTRL interface (%s)" % self.desc_link())
+
 	def handle_rx(self):
 		# Read data from socket
 		data, remote = self.sock.recvfrom(128)
diff --git a/src/target/trx_toolkit/ctrl_if_trx.py b/src/target/trx_toolkit/ctrl_if_trx.py
index 0d4935d..26a844f 100644
--- a/src/target/trx_toolkit/ctrl_if_trx.py
+++ b/src/target/trx_toolkit/ctrl_if_trx.py
@@ -46,7 +46,6 @@
 
 	def __init__(self, trx, *udp_link_args):
 		CTRLInterface.__init__(self, *udp_link_args)
-		log.info("Init CTRL interface (%s)" % self.desc_link())
 
 		# Link with Transceiver instance we belong to
 		self.trx = trx
diff --git a/src/target/trx_toolkit/data_if.py b/src/target/trx_toolkit/data_if.py
index a773c04..b1ba1e5 100644
--- a/src/target/trx_toolkit/data_if.py
+++ b/src/target/trx_toolkit/data_if.py
@@ -28,6 +28,10 @@
 from data_msg import *
 
 class DATAInterface(UDPLink):
+	def __init__(self, *udp_link_args):
+		UDPLink.__init__(self, *udp_link_args)
+		log.debug("Init DATA interface (%s)" % self.desc_link())
+
 	def recv_raw_data(self):
 		data, _ = self.sock.recvfrom(512)
 		return data

-- 
To view, visit https://gerrit.osmocom.org/12547
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
Gerrit-Change-Number: 12547
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190114/3737fea5/attachment.htm>


More information about the gerrit-log mailing list