This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 ) Change subject: Add SGs Interface ...................................................................... Patch Set 29: (2 comments) https://gerrit.osmocom.org/#/c/11642/29/src/libvlr/vlr_sgs.c File src/libvlr/vlr_sgs.c: https://gerrit.osmocom.org/#/c/11642/29/src/libvlr/vlr_sgs.c@89 PS29, Line 89: memcpy(&vsub->sgs.cfg, cfg, sizeof(vsub->sgs.cfg)); rather vsub->sgs.cfg = *cfg; https://gerrit.osmocom.org/#/c/11642/29/src/libvlr/vlr_sgs.c@101 PS29, Line 101: memcpy(&vsub->cgi, new_lai, sizeof(vsub->sgs.lai)); please don't use memcpy, but assign members directly. That ensures that you don't copy over mismatching formats. vsub->sgs.lai = *new_lai; vsub->cgi.lai = *new_lai; -- To view, visit https://gerrit.osmocom.org/11642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73359925fc1ca72b33a1466e6ac41307f2f0b11d Gerrit-Change-Number: 11642 Gerrit-PatchSet: 29 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-CC: Stefan Sperling <stsp at stsp.name> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Mon, 14 Jan 2019 17:47:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190114/0c058971/attachment.htm>