Change in osmo-msc[master]: Store subscriber's cell identity in ran_conn

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jan 14 17:37:56 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11746 )

Change subject: Store subscriber's cell identity in ran_conn
......................................................................


Patch Set 6:

(1 comment)

Meta: AFAIK we already store the entire CGI in the vlr_subscr?
maybe we should instead drop the LAC info from struct ran_conn completely?
(code looks like we are never storing the CI part of vls_subscr->cgi, that would be nice to fix)

Meta meta: in the course of inter-MSC HO I am refactoring what the ran_conn represents, so I'd prefer to park this patch and revisit after the inter-MSC changes, to avoid merge conflicts and back-and-forths.

https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:

https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c@320
PS2, Line 320: 	case CELL_IDENT_CI:
a CELL_IDENT_CI is *only* a CI without a LAC; since any CI number can be re-used within each LAC, the CELL_IDENT_CI is intrinsically ambiguous.
I'm not sure who thought of specifying this Cell Identifier type, maybe it makes sense if your network has only one LAC??
Haven't seen it used anywhere.

I think it's okay to require a LAC, so I'd rather drop the FIXME comment.



-- 
To view, visit https://gerrit.osmocom.org/11746
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8544c30ea800ce8356a227b03a8b21bf3252be7e
Gerrit-Change-Number: 11746
Gerrit-PatchSet: 6
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 14 Jan 2019 17:37:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190114/1e10c64b/attachment.htm>


More information about the gerrit-log mailing list