Change in openbsc[master]: Don't send SMS STATUS REPORT locally if the ESME accepted it.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Jan 13 12:31:46 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12538 )

Change subject: Don't send SMS STATUS REPORT locally if the ESME accepted it.
......................................................................

Don't send SMS STATUS REPORT locally if the ESME accepted it.

Backport of https://gerrit.osmocom.org/11792/

When using smpp-first, after the ESME accepts our STATUS REPORT,
we were sending it locally into gsm340_rx_sms_submit() anyway.
In the case of the ESME mirroring the report back to us, this
would result in two copies of the status report in the SMS
database, which were also both then delivered to the MS.
Some MS then display the REPORT to the user as if it were
a normal SMS.

With this patch, we check if it is the sms_report that has had
receiver set in sms_route_mt_sms() and not the original SMS we
are reporting on, which of course already has receiver set.

Change-Id: I2136489bd21c4755463278a4048a446e5bc4a9d2
---
M openbsc/src/libmsc/gsm_04_11.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/openbsc/src/libmsc/gsm_04_11.c b/openbsc/src/libmsc/gsm_04_11.c
index 25ef487..d5619b2 100644
--- a/openbsc/src/libmsc/gsm_04_11.c
+++ b/openbsc/src/libmsc/gsm_04_11.c
@@ -697,7 +697,7 @@
 	}
 
 	/* No route via SMPP, send the GSM 03.40 status-report now. */
-	if (gsms->receiver)
+	if (sms_report->receiver)
 		gsm340_rx_sms_submit(sms_report);
 
 	LOGP(DLSMS, LOGL_NOTICE, "Status report has been sent\n");

-- 
To view, visit https://gerrit.osmocom.org/12538
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2136489bd21c4755463278a4048a446e5bc4a9d2
Gerrit-Change-Number: 12538
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190113/8a10a78f/attachment.htm>


More information about the gerrit-log mailing list