This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/12478 ) Change subject: VLR: send CHECK-IMEI to EIR/HLR ...................................................................... Patch Set 8: (2 comments) https://gerrit.osmocom.org/#/c/12478/8/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/#/c/12478/8/src/libvlr/vlr.c@1016 PS8, Line 1016: (void *)&gsup->cause); > What is the meaning of cause in successful case? Oh, I realize now that I had copied the (void *)&gsup->cause argument from vlr_subscr_handle_lu_err() above, without thinking too much about it. You are right, on ACK and NACK the gsup->cause is not set. And even where it is set at ERROR below, we already log it. So there is not really a point in sending the gsup->cause as userdata along with osmo_fsm_inst_dispatch. The function that gets called from the dispatch, lu_compl_vlr_wait_imei() in vlr_lu_fsm.c, ignores the data argument anyway. I'll just remove the argument. Good catch, thanks! https://gerrit.osmocom.org/#/c/12478/8/src/libvlr/vlr.c@1018 PS8, Line 1018: (void *)&gsup->cause); > Same here, isn't it only being sent when msgt == OSMO_GSUP_MSGT_CHECK_IMEI_ERROR? (see above) -- To view, visit https://gerrit.osmocom.org/12478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife868ed71c36cdd02638072abebf61fc949080a7 Gerrit-Change-Number: 12478 Gerrit-PatchSet: 8 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Fri, 11 Jan 2019 14:10:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190111/f37cd63e/attachment.htm>