Change in osmo-msc[master]: transaction: drop unused ti_flag

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Jan 10 17:45:01 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12519 )

Change subject: transaction: drop unused ti_flag
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/12519/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12519/1//COMMIT_MSG@10
PS1, Line 10: It's unclear what was the initial intention for it
AFAIR, ti_flag is used to indicate the origin of a transaction:

  - '0'B means that a given message comes *from* the side
    that originates the transaction,
  - '1'B means that a given message comes *to* the side
    that originates the transaction.

I am not sure if we should drop it just because the callers always pass '0'B.


https://gerrit.osmocom.org/#/c/12519/1//COMMIT_MSG@10
PS1, Line 10: unused
Actually, it's used, but '0'B is always passed.



-- 
To view, visit https://gerrit.osmocom.org/12519
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie11999900b1789652ee078d34636dcda1e137eb0
Gerrit-Change-Number: 12519
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 10 Jan 2019 17:45:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190110/cd90a5fd/attachment.htm>


More information about the gerrit-log mailing list