Change in osmo-gsm-tester[master]: mobile: Switch from removed cli option to vty port

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12445 )

Change subject: mobile: Switch from removed cli option to vty port
......................................................................

mobile: Switch from removed cli option to vty port

Bind the mobile's to a random (chosen by the kernel) VTY port. The
CLI option was removed and I added a new VTY command to be able to
specify the port in addition to the address.


Change-Id: Ie40a2ba156ba5674d37a15eb30e5b2527e75fbe7
---
M src/osmo_gsm_tester/templates/osmo-mobile.cfg.tmpl
M src/osmo_ms_driver/starter.py
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/templates/osmo-mobile.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-mobile.cfg.tmpl
index 395d6f4..0a2cd6d 100644
--- a/src/osmo_gsm_tester/templates/osmo-mobile.cfg.tmpl
+++ b/src/osmo_gsm_tester/templates/osmo-mobile.cfg.tmpl
@@ -1,3 +1,5 @@
+line vty
+ bind 127.0.0.1 0
 no gps enable
 no hide-default
 ms ${test.ms_number}
diff --git a/src/osmo_ms_driver/starter.py b/src/osmo_ms_driver/starter.py
index bf7727f..dd3aac5 100644
--- a/src/osmo_ms_driver/starter.py
+++ b/src/osmo_ms_driver/starter.py
@@ -121,7 +121,7 @@
 
         self.log("Starting mobile")
         # Let the kernel pick an unused port for the VTY.
-        args = [self._binary, "-c", mob_filename, "--vty-port=0"]
+        args = [self._binary, "-c", mob_filename]
         self._omob_proc = process.Process(self.name(), self._tmp_dir,
                                           args, env=self._env)
         if suite_run:

-- 
To view, visit https://gerrit.osmocom.org/12445
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie40a2ba156ba5674d37a15eb30e5b2527e75fbe7
Gerrit-Change-Number: 12445
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190110/238f06f6/attachment.htm>