This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12470 ) Change subject: add LOG_RAN_CONN() to use the conn->fi->id for context ...................................................................... Patch Set 2: (1 comment) Anyway, changing the logging messages is behind the scope of this change. This is the reason of my -1, sorry. https://gerrit.osmocom.org/#/c/12470/2/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/#/c/12470/2/src/libmsc/gsm_04_08.c@724 PS2, Line 724: sizeof(struct gsm48_service_request*) Oh, wow, it looks like your sizeof was copy-pasted from here. I think it should be fixed in a separate change, and changed to: sizeof(*req) or sizeof(struct gsm48_service_request) -- To view, visit https://gerrit.osmocom.org/12470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a7809840428b1e028df6eb683bc5ffcc8df474a Gerrit-Change-Number: 12470 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-CC: Max <msuraev at sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jan 2019 12:10:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190110/e30b6501/attachment.htm>