Change in osmo-msc[master]: add LOG_RAN_CONN() to use the conn->fi->id for context

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Jan 10 11:59:51 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12470 )

Change subject: add LOG_RAN_CONN() to use the conn->fi->id for context
......................................................................


Patch Set 2: Code-Review-1

(7 comments)

https://gerrit.osmocom.org/#/c/12470/2/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:

https://gerrit.osmocom.org/#/c/12470/2/src/libmsc/gsm_04_08.c@343
PS2, Line 343:      
(one of the reasons why this space-alignment sucks)

Shouldn't this part be (re)aligned?
Or should we just switch to a single tab? ;)


https://gerrit.osmocom.org/#/c/12470/2/src/libmsc/gsm_04_08.c@351
PS2, Line 351:      
same


https://gerrit.osmocom.org/#/c/12470/2/src/libmsc/gsm_04_08.c@360
PS2, Line 360:      
same


https://gerrit.osmocom.org/#/c/12470/2/src/libmsc/gsm_04_08.c@596
PS2, Line 596: Tx
why should we change this in this change?


https://gerrit.osmocom.org/#/c/12470/2/src/libmsc/gsm_04_08.c@616
PS2, Line 616: Tx
same


https://gerrit.osmocom.org/#/c/12470/2/src/libmsc/gsm_04_08.c@725
PS2, Line 725: message size
same


https://gerrit.osmocom.org/#/c/12470/2/src/libmsc/gsm_04_08.c@726
PS2, Line 726: sizeof(struct gsm48_service_request*)
Size of pointer?!?



-- 
To view, visit https://gerrit.osmocom.org/12470
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a7809840428b1e028df6eb683bc5ffcc8df474a
Gerrit-Change-Number: 12470
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jan 2019 11:59:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190110/6a7f3757/attachment.htm>


More information about the gerrit-log mailing list