Change in libosmocore[master]: Cosmetic: GSUP: note "on wire" for imei_result

[osmith]

osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/12488 )

Change subject: Cosmetic: GSUP: note "on wire" for imei_result
......................................................................

Cosmetic: GSUP: note "on wire" for imei_result

Note that OSMO_GSUP_IMEI_RESULT_ACK is 0 on the wire, although the
enum value is 1. Same with NACK (1 on wire, enum 2).

I had implemented enum osmo_gsup_imei_result after
enum osmo_gsup_cancel_type above, where this comment exists as well,
and I incorrectly assumed that enum osmo_gsup_cn_domain in the middle
was also implemented this way and therefore adding the comments to each
enum would be redundant. But for cn_domain, the values on the wire are
the same as the enum values.

Change-Id: If97c34f117bfaab2232bbb625e9d118c8f390e58
---
M include/osmocom/gsm/gsup.h
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Max: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/gsup.h b/include/osmocom/gsm/gsup.h
index 6adb0bf..5dc2a82 100644
--- a/include/osmocom/gsm/gsup.h
+++ b/include/osmocom/gsm/gsup.h
@@ -174,8 +174,8 @@
 };
 
 enum osmo_gsup_imei_result {
-	OSMO_GSUP_IMEI_RESULT_ACK		= 1,
-	OSMO_GSUP_IMEI_RESULT_NACK		= 2,
+	OSMO_GSUP_IMEI_RESULT_ACK		= 1, /* on wire: 0 */
+	OSMO_GSUP_IMEI_RESULT_NACK		= 2, /* on wire: 1 */
 };
 
 /*! TCAP-like session state */

-- 
To view, visit https://gerrit.osmocom.org/12488
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If97c34f117bfaab2232bbb625e9d118c8f390e58
Gerrit-Change-Number: 12488
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190109/9e2c287b/attachment.htm>