Change in osmo-bsc[master]: fix lchan modifications: switch off re-using lchan during assignment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jan 9 14:11:49 UTC 2019


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/12401

to look at the new patch set (#3).

Change subject: fix lchan modifications: switch off re-using lchan during assignment
......................................................................

fix lchan modifications: switch off re-using lchan during assignment

Always set up a fresh lchan for both SDCCH->TCH/* as well as call-during-call,
which allows these scenarios to properly set up an RTP stream.

Disable lchan re-use on repeated Assignment Requests: so far the lchan FSM does
RTP handling properly *only* when it 'requires_voice_stream' from the start.

The nicer way to support call-during-call, as well as Channel Mode Modify,
would be to rather re-use the old lchan and implement FSM states to re-route
the audio. But that is a task for another day.

A more detailed explanation is given in the '#if 0' section added by this
patch.

To really get call-during-call working, osmo-msc also needs a fix, see the
change-id in 'Related' below.

Related: OS#3735, osmo-msc I0ba216b737909e92080a722db26e3577726c63cb
Change-Id: I0c00ec2c120e5008281755adcd4944a3ce4d8355
---
M src/osmo-bsc/assignment_fsm.c
1 file changed, 37 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/12401/3
-- 
To view, visit https://gerrit.osmocom.org/12401
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0c00ec2c120e5008281755adcd4944a3ce4d8355
Gerrit-Change-Number: 12401
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190109/ec38c2a7/attachment.htm>


More information about the gerrit-log mailing list