Change in osmo-bsc[master]: fix call-during-call: switch off re-using lchan during assignment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jan 9 14:03:24 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12401 )

Change subject: fix call-during-call: switch off re-using lchan during assignment
......................................................................


Patch Set 2:

> I'm not really buying the argument about a "rare" case.

Maybe that's the wrong argument, then. The better one is: untested; and: AFAICT we cannot possibly handle that correctly, because I am pretty sure the lchan FSM only does RTP handling properly when it is activated with 'requires_voice_stream' enabled, and so far has no code path to enable it later, yet.


-- 
To view, visit https://gerrit.osmocom.org/12401
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c00ec2c120e5008281755adcd4944a3ce4d8355
Gerrit-Change-Number: 12401
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 09 Jan 2019 14:03:24 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190109/9b79b95f/attachment.htm>


More information about the gerrit-log mailing list