Change in osmo-msc[master]: add LOG_RAN_CONN() to use the conn->fi->id for context

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12470 )

Change subject: add LOG_RAN_CONN() to use the conn->fi->id for context
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12470/1/tests/msc_vlr/msc_vlr_test_hlr_reject.err
File tests/msc_vlr/msc_vlr_test_hlr_reject.err:

https://gerrit.osmocom.org/#/c/12470/1/tests/msc_vlr/msc_vlr_test_hlr_reject.err@12
PS1, Line 12: DMM RAN_conn(LU:901700000004620) LOCATION UPDATING REQUEST: MI(IMSI)=901700000004620 type=IMSI ATTACH
> Seems like we log duplicated information now.
yes.

This patch generally adds context information to conn related logging.
It doesn't change what the log strings contain.
When a LU request comes in, we log the Mobile Identity and type;
we could now remove the MI logging from the log string since it is already in the FSM id.
But since this happens only once when a L3 complete request comes in, I'd just keep it.



-- 
To view, visit https://gerrit.osmocom.org/12470
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a7809840428b1e028df6eb683bc5ffcc8df474a
Gerrit-Change-Number: 12470
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Jan 2019 14:14:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190108/9ebedaa0/attachment.htm>