This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/12302 ) Change subject: msc_vty.c: configurable retrieval of IMEI, IMEISV ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/12302/1/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/12302/1/src/libmsc/msc_vty.c@437 PS1, Line 437: "Send each IMEI to the EIR to ask if it is permitted or not. The EIR is implemented as part of osmo-hlr, " > slightly out-of-scope, we don't know whether the user is using OsmoHLR or something else. True, but I think it would make it a lot easier to understand for the users, what this option is for. If they don't use OsmoHLR, then they can ignore that sentence. With that in mind, do you still prefer to have it removed? https://gerrit.osmocom.org/#/c/12302/1/src/libmsc/msc_vty.c@440 PS1, Line 440: "1 = send each IMEI to the EIR\n") > (we normally don't name the values again, just write the string for that value. […] Ack, and I'll submit a patch later to fix this in the description above. -- To view, visit https://gerrit.osmocom.org/12302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee516b9cd7877b21207ce9a6d954109f19558163 Gerrit-Change-Number: 12302 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-CC: Max <msuraev at sysmocom.de> Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-CC: Stefan Sperling <stsp at stsp.name> Gerrit-Comment-Date: Mon, 07 Jan 2019 16:09:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190107/c4094144/attachment.htm>