Change in libosmocore[master]: add osmo_lu_type_names[], osmo_lu_type_name()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Jan 7 15:14:46 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12469 )

Change subject: add osmo_lu_type_names[], osmo_lu_type_name()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12469/2/src/gsm/gsm48.c
File src/gsm/gsm48.c:

https://gerrit.osmocom.org/#/c/12469/2/src/gsm/gsm48.c@1144
PS2, Line 1144: {}
> yes, and there is no reason to name the elements if it's all to be default-initialized... […]
I don't think we have any value_string arrays that are terminated this way.  I would really argue in favor of consistency than whatever other arguments.



-- 
To view, visit https://gerrit.osmocom.org/12469
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica25919758ef6cba8348da199b0ae7e0ba628798
Gerrit-Change-Number: 12469
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Mon, 07 Jan 2019 15:14:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190107/694aa3e9/attachment.htm>


More information about the gerrit-log mailing list