Change in libosmocore[master]: port rest octets encoding code from osmo-bsc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Mon Jan 7 12:17:39 UTC 2019


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10189 )

Change subject: port rest octets encoding code from osmo-bsc
......................................................................


Patch Set 6:

(2 comments)

https://gerrit.osmocom.org/#/c/10189/6/include/osmocom/gprs/protocol/gsm_04_60.h
File include/osmocom/gprs/protocol/gsm_04_60.h:

https://gerrit.osmocom.org/#/c/10189/6/include/osmocom/gprs/protocol/gsm_04_60.h@338
PS6, Line 338: 			uint8_t use_egprs_p_ch_req;
> Extra tabs looks off.
Indeed, thanks. Fixed in next patch set.


https://gerrit.osmocom.org/#/c/10189/6/src/gsm/gsm48_rest_octets.c
File src/gsm/gsm48_rest_octets.c:

https://gerrit.osmocom.org/#/c/10189/6/src/gsm/gsm48_rest_octets.c@64
PS6, Line 64: #define SI2Q_MIN_LEN 18
> Those are used in 3 different files in OsmoBSC - any reason for not making this part of public heade […]
Sure, I will move these to the public header in the next patch set.



-- 
To view, visit https://gerrit.osmocom.org/10189
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47888965ab11bba1186c21987f1365c9270abeab
Gerrit-Change-Number: 10189
Gerrit-PatchSet: 6
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Jan 2019 12:17:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190107/e4cd2f78/attachment.htm>


More information about the gerrit-log mailing list