Change in libosmocore[master]: add osmo_lu_type_names[], osmo_lu_type_name()

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12469 )

Change subject: add osmo_lu_type_names[], osmo_lu_type_name()
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/12469/2/src/gsm/gsm48.c
File src/gsm/gsm48.c:

https://gerrit.osmocom.org/#/c/12469/2/src/gsm/gsm48.c@1141
PS2, Line 1141: GSM48_LUPD_NORMAL
> BTW: what about GSM48_LUPD_RESERVED?
what do you mean? I am basically moving


https://gerrit.osmocom.org/#/c/12469/2/src/gsm/gsm48.c@1144
PS2, Line 1144: { 
> cosmetic: in other 'value_string' statements of this file '{ 0, NULL }' is used.
yes, and there is no reason to name the elements if it's all to be default-initialized...
verify_value_string_arrays_are_terminated.py in osmo-ci does accept both.

There has been a lengthy discussion about {} vs {0} elsewhere, I don't think we agreed on anything.
I'm a '{}' advocate.



-- 
To view, visit https://gerrit.osmocom.org/12469
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica25919758ef6cba8348da199b0ae7e0ba628798
Gerrit-Change-Number: 12469
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sun, 06 Jan 2019 22:01:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190106/6769b74f/attachment.htm>