Change in libosmocore[master]: add osmo_mi_name(), for MI-to-string like "IMSI-123456"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat Jan 5 11:30:44 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12468 )

Change subject: add osmo_mi_name(), for MI-to-string like "IMSI-123456"
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

Fine with me, just a few cosmetic issues.

https://gerrit.osmocom.org/#/c/12468/2/src/gsm/gsm48.c
File src/gsm/gsm48.c:

https://gerrit.osmocom.org/#/c/12468/2/src/gsm/gsm48.c@441
PS2, Line 441: mi[]
I know that an array in C is basically a pointer to its first
element. So, both 'uint8_t mi[]' and 'uint8_t *mi' are equal.

But in most cases we are using 'type *foo', while 'type arr[]'
is more suitable for complex arrays, e.g. arrays of structs.

In this case we are dealing with a buffer, so let's use 'uint8_t *mi'.


https://gerrit.osmocom.org/#/c/12468/2/src/gsm/gsm48.c@451
PS2, Line 451: default
We usually put the 'default' statement below all 'case' statements.
Why this 'switch' is doing vice-versa? Any advantages of that?



-- 
To view, visit https://gerrit.osmocom.org/12468
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7798c3ef983c2e333b2b9cbffef6f366f370bd81
Gerrit-Change-Number: 12468
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 05 Jan 2019 11:30:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190105/04b7de04/attachment.htm>


More information about the gerrit-log mailing list