This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12398 ) Change subject: remove code dup: add msc_mgcp_try_call_assignment() ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/12398/3/src/libmsc/msc_mgcp.c File src/libmsc/msc_mgcp.c: https://gerrit.osmocom.org/#/c/12398/3/src/libmsc/msc_mgcp.c@964 PS3, Line 964: return 0; Maybe it's a good idea to print some NOTICE here? https://gerrit.osmocom.org/#/c/12398/3/src/libmsc/msc_mgcp.c@966 PS3, Line 966: trans->assignment_done = true; The log line says that call assignment is being started, but here you're setting 'assignment_done' to true. This looks a bit confusing to me. What if msc_mgcp_call_assignment() would fail? Shouldn't we check the rc before setting 'assignment_done'? -- To view, visit https://gerrit.osmocom.org/12398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c0b7dc3f1a747028629b48e522bb3b864884ba Gerrit-Change-Number: 12398 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 03 Jan 2019 12:19:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190103/fc0abac8/attachment.htm>